Skip to content

Commit

Permalink
Remove unchecked MTD flags
Browse files Browse the repository at this point in the history
Several flags are set by some devices, but never checked.  Remove them.

Signed-off-by: Jörn Engel <[email protected]>
Signed-off-by: David Woodhouse <[email protected]>
  • Loading branch information
Jörn Engel authored and dwmw2 committed Apr 17, 2006
1 parent af63a3b commit a6c591e
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 13 deletions.
2 changes: 1 addition & 1 deletion drivers/mtd/chips/map_ram.c
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ static struct mtd_info *map_ram_probe(struct map_info *map)
mtd->read = mapram_read;
mtd->write = mapram_write;
mtd->sync = mapram_nop;
mtd->flags = MTD_CAP_RAM | MTD_VOLATILE;
mtd->flags = MTD_CAP_RAM;

mtd->erasesize = PAGE_SIZE;
while(mtd->size & (mtd->erasesize - 1))
Expand Down
2 changes: 1 addition & 1 deletion drivers/mtd/devices/phram.c
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ static int register_device(char *name, unsigned long start, unsigned long len)

new->mtd.name = name;
new->mtd.size = len;
new->mtd.flags = MTD_CAP_RAM | MTD_ERASEABLE | MTD_VOLATILE;
new->mtd.flags = MTD_CAP_RAM;
new->mtd.erase = phram_erase;
new->mtd.point = phram_point;
new->mtd.unpoint = phram_unpoint;
Expand Down
3 changes: 1 addition & 2 deletions drivers/mtd/devices/slram.c
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,7 @@ static int register_device(char *name, unsigned long start, unsigned long length

(*curmtd)->mtdinfo->name = name;
(*curmtd)->mtdinfo->size = length;
(*curmtd)->mtdinfo->flags = MTD_CLEAR_BITS | MTD_SET_BITS |
MTD_WRITEB_WRITEABLE | MTD_VOLATILE | MTD_CAP_RAM;
(*curmtd)->mtdinfo->flags = MTD_CAP_RAM;
(*curmtd)->mtdinfo->erase = slram_erase;
(*curmtd)->mtdinfo->point = slram_point;
(*curmtd)->mtdinfo->unpoint = slram_unpoint;
Expand Down
12 changes: 3 additions & 9 deletions include/mtd/mtd-abi.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,20 +35,14 @@ struct mtd_oob_buf {

#define MTD_CLEAR_BITS 1 // Bits can be cleared (flash)
#define MTD_SET_BITS 2 // Bits can be set
#define MTD_ERASEABLE 4 // Has an erase function
#define MTD_WRITEB_WRITEABLE 8 // Direct IO is possible
#define MTD_VOLATILE 16 // Set for RAMs
#define MTD_XIP 32 // eXecute-In-Place possible
#define MTD_OOB 64 // Out-of-band data (NAND flash)
#define MTD_ECC 128 // Device capable of automatic ECC
#define MTD_NO_VIRTBLOCKS 256 // Virtual blocks not allowed
#define MTD_PROGRAM_REGIONS 512 // Configurable Programming Regions

// Some common devices / combinations of capabilities
#define MTD_CAP_ROM 0
#define MTD_CAP_RAM (MTD_CLEAR_BITS|MTD_SET_BITS|MTD_WRITEB_WRITEABLE)
#define MTD_CAP_NORFLASH (MTD_CLEAR_BITS|MTD_ERASEABLE)
#define MTD_CAP_NANDFLASH (MTD_CLEAR_BITS|MTD_ERASEABLE|MTD_OOB)
#define MTD_CAP_RAM (MTD_CLEAR_BITS|MTD_SET_BITS)
#define MTD_CAP_NORFLASH (MTD_CLEAR_BITS)
#define MTD_CAP_NANDFLASH (MTD_CLEAR_BITS)
#define MTD_WRITEABLE (MTD_CLEAR_BITS|MTD_SET_BITS)


Expand Down

0 comments on commit a6c591e

Please sign in to comment.