Skip to content

Commit

Permalink
Input: make input_class constant
Browse files Browse the repository at this point in the history
Since commit 43a7206 ("driver core: class: make class_register() take
a const *"), the driver core allows for struct class to be in read-only
memory, so move the input_class structure to be declared at build time
placing it into read-only memory, instead of having to be dynamically
allocated at boot time.

Suggested-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Ricardo B. Marliere <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Dmitry Torokhov <[email protected]>
  • Loading branch information
rbmarliere authored and dtor committed Mar 10, 2024
1 parent 1099a04 commit a4735d4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/input/input.c
Original file line number Diff line number Diff line change
Expand Up @@ -1918,7 +1918,7 @@ static char *input_devnode(const struct device *dev, umode_t *mode)
return kasprintf(GFP_KERNEL, "input/%s", dev_name(dev));
}

struct class input_class = {
const struct class input_class = {
.name = "input",
.devnode = input_devnode,
};
Expand Down
2 changes: 1 addition & 1 deletion include/linux/input.h
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ void input_enable_softrepeat(struct input_dev *dev, int delay, int period);

bool input_device_enabled(struct input_dev *dev);

extern struct class input_class;
extern const struct class input_class;

/**
* struct ff_device - force-feedback part of an input device
Expand Down

0 comments on commit a4735d4

Please sign in to comment.