Skip to content

Commit

Permalink
MBCS: convert algolock to mutex
Browse files Browse the repository at this point in the history
MBCS: Convert the semaphore algolock to the mutex API

Signed-off-by: Matthias Kaehlcke <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Matthias Kaehlcke authored and Linus Torvalds committed Feb 7, 2008
1 parent 92df5c3 commit a40ba84
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
7 changes: 4 additions & 3 deletions drivers/char/mbcs.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include <linux/device.h>
#include <linux/mm.h>
#include <linux/uio.h>
#include <linux/mutex.h>
#include <asm/io.h>
#include <asm/uaccess.h>
#include <asm/system.h>
Expand Down Expand Up @@ -281,7 +282,7 @@ static inline int mbcs_algo_start(struct mbcs_soft *soft)
void *mmr_base = soft->mmr_base;
union cm_control cm_control;

if (down_interruptible(&soft->algolock))
if (mutex_lock_interruptible(&soft->algolock))
return -ERESTARTSYS;

atomic_set(&soft->algo_done, 0);
Expand All @@ -298,7 +299,7 @@ static inline int mbcs_algo_start(struct mbcs_soft *soft)
cm_control.alg_go = 1;
MBCS_MMR_SET(mmr_base, MBCS_CM_CONTROL, cm_control.cm_control_reg);

up(&soft->algolock);
mutex_unlock(&soft->algolock);

return 0;
}
Expand Down Expand Up @@ -764,7 +765,7 @@ static int mbcs_probe(struct cx_dev *dev, const struct cx_device_id *id)

init_MUTEX(&soft->dmawritelock);
init_MUTEX(&soft->dmareadlock);
init_MUTEX(&soft->algolock);
mutex_init(&soft->algolock);

mbcs_getdma_init(&soft->getdma);
mbcs_putdma_init(&soft->putdma);
Expand Down
2 changes: 1 addition & 1 deletion drivers/char/mbcs.h
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ struct mbcs_soft {
atomic_t algo_done;
struct semaphore dmawritelock;
struct semaphore dmareadlock;
struct semaphore algolock;
struct mutex algolock;
};

static int mbcs_open(struct inode *ip, struct file *fp);
Expand Down

0 comments on commit a40ba84

Please sign in to comment.