Skip to content

Commit

Permalink
mfd: lm3533: Simplify function return logic
Browse files Browse the repository at this point in the history
The invoked functions already return zero on success or a negative
errno code so there is no need to open code the logic in the caller.

Signed-off-by: Javier Martinez Canillas <[email protected]>
Signed-off-by: Lee Jones <[email protected]>
  • Loading branch information
Javier Martinez Canillas authored and Lee Jones committed Oct 30, 2015
1 parent 5597da2 commit a1c16d7
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions drivers/mfd/lm3533-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -472,11 +472,7 @@ static int lm3533_device_setup(struct lm3533 *lm3533,
if (ret)
return ret;

ret = lm3533_set_boost_ovp(lm3533, pdata->boost_ovp);
if (ret)
return ret;

return 0;
return lm3533_set_boost_ovp(lm3533, pdata->boost_ovp);
}

static int lm3533_device_init(struct lm3533 *lm3533)
Expand Down Expand Up @@ -613,11 +609,7 @@ static int lm3533_i2c_probe(struct i2c_client *i2c,
lm3533->dev = &i2c->dev;
lm3533->irq = i2c->irq;

ret = lm3533_device_init(lm3533);
if (ret)
return ret;

return 0;
return lm3533_device_init(lm3533);
}

static int lm3533_i2c_remove(struct i2c_client *i2c)
Expand Down

0 comments on commit a1c16d7

Please sign in to comment.