Skip to content

Commit

Permalink
parport: quoted strings should not be split
Browse files Browse the repository at this point in the history
user visible strings should not be split as that affects the ability to
grep.

Signed-off-by: Sudip Mukherjee <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
sudipm-mukherjee authored and gregkh committed Jan 4, 2016
1 parent b075e6f commit a162188
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions drivers/parport/share.c
Original file line number Diff line number Diff line change
Expand Up @@ -537,9 +537,8 @@ void parport_announce_port (struct parport *port)
#endif

if (!port->dev)
printk(KERN_WARNING "%s: fix this legacy "
"no-device port driver!\n",
port->name);
printk(KERN_WARNING "%s: fix this legacy no-device port driver!\n",
port->name);

parport_proc_register(port);
mutex_lock(&registration_lock);
Expand Down Expand Up @@ -778,8 +777,8 @@ parport_register_device(struct parport *port, const char *name,
if (port->physport->devices) {
spin_unlock (&port->physport->pardevice_lock);
printk (KERN_DEBUG
"%s: cannot grant exclusive access for "
"device %s\n", port->name, name);
"%s: cannot grant exclusive access for device %s\n",
port->name, name);
goto out_free_all;
}
port->flags |= PARPORT_FLAG_EXCL;
Expand Down Expand Up @@ -1276,9 +1275,8 @@ int parport_claim_or_block(struct pardevice *dev)

#ifdef PARPORT_DEBUG_SHARING
if (dev->port->physport->cad != dev)
printk(KERN_DEBUG "%s: exiting parport_claim_or_block "
"but %s owns port!\n", dev->name,
dev->port->physport->cad ?
printk(KERN_DEBUG "%s: exiting parport_claim_or_block but %s owns port!\n",
dev->name, dev->port->physport->cad ?
dev->port->physport->cad->name:"nobody");
#endif
}
Expand Down Expand Up @@ -1306,8 +1304,8 @@ void parport_release(struct pardevice *dev)
write_lock_irqsave(&port->cad_lock, flags);
if (port->cad != dev) {
write_unlock_irqrestore (&port->cad_lock, flags);
printk(KERN_WARNING "%s: %s tried to release parport "
"when not owner\n", port->name, dev->name);
printk(KERN_WARNING "%s: %s tried to release parport when not owner\n",
port->name, dev->name);
return;
}

Expand Down

0 comments on commit a162188

Please sign in to comment.