bdi: add error handle for bdi_debug_register

In order to make error handle more cleaner we call bdi_debug_register before set state to WB_registered, that we can avoid call bdi_unregister in release_bdi(). Reviewed-by: Jan Kara <[email protected]> Signed-off-by: weiping zhang <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
chewitt · Nov 19, 2017 · a0747a8 · a0747a8
1 parent 97f0769
commit a0747a8
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/mm/backing-dev.c b/mm/backing-dev.c
@@ -882,10 +882,13 @@ int bdi_register_va(struct backing_dev_info *bdi, const char *fmt, va_list args)
 	if (IS_ERR(dev))
 		return PTR_ERR(dev);
 
+	if (bdi_debug_register(bdi, dev_name(dev))) {
+		device_destroy(bdi_class, dev->devt);
+		return -ENOMEM;
+	}
 	cgwb_bdi_register(bdi);
 	bdi->dev = dev;
 
-	bdi_debug_register(bdi, dev_name(dev));
 	set_bit(WB_registered, &bdi->wb.state);
 
 	spin_lock_bh(&bdi_lock);