Skip to content

Commit

Permalink
lib/cmdline.c: fix style issues
Browse files Browse the repository at this point in the history
WARNING: space prohibited between function name and open parenthesis '('
+int get_option (char **str, int *pint)

WARNING: space prohibited between function name and open parenthesis '('
+	*pint = simple_strtol (cur, str, 0);

ERROR: trailing whitespace
+ $

WARNING: please, no spaces at the start of a line
+ $

WARNING: space prohibited between function name and open parenthesis '('
+		res = get_option ((char **)&str, ints + i);

Signed-off-by: Felipe Contreras <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
felipec authored and torvalds committed Jan 24, 2014
1 parent ae2924a commit 9fd4305
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions lib/cmdline.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,13 @@ static int get_range(char **str, int *pint)
* 3 - hyphen found to denote a range
*/

int get_option (char **str, int *pint)
int get_option(char **str, int *pint)
{
char *cur = *str;

if (!cur || !(*cur))
return 0;
*pint = simple_strtol (cur, str, 0);
*pint = simple_strtol(cur, str, 0);
if (cur == *str)
return 0;
if (**str == ',') {
Expand Down Expand Up @@ -84,13 +84,13 @@ int get_option (char **str, int *pint)
* the parse to end (typically a null terminator, if @str is
* completely parseable).
*/

char *get_options(const char *str, int nints, int *ints)
{
int res, i = 1;

while (i < nints) {
res = get_option ((char **)&str, ints + i);
res = get_option((char **)&str, ints + i);
if (res == 0)
break;
if (res == 3) {
Expand Down Expand Up @@ -153,7 +153,6 @@ unsigned long long memparse(const char *ptr, char **retptr)
return ret;
}


EXPORT_SYMBOL(memparse);
EXPORT_SYMBOL(get_option);
EXPORT_SYMBOL(get_options);

0 comments on commit 9fd4305

Please sign in to comment.