Skip to content

Commit

Permalink
Revert "ide: skip probe if there are no devices on the port (v2)"
Browse files Browse the repository at this point in the history
This reverts commit a20b2a4.

As requested by David Fries.  This makes CDROMs which are slave drives
on a ribbon without a master disappear and causes other similar kinds
of badness.

Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
davem330 committed Mar 29, 2010
1 parent e4afb29 commit 9ce41ae
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions drivers/ide/ide-probe.c
Original file line number Diff line number Diff line change
Expand Up @@ -695,14 +695,8 @@ static int ide_probe_port(ide_hwif_t *hwif)
if (irqd)
disable_irq(hwif->irq);

rc = ide_port_wait_ready(hwif);
if (rc == -ENODEV) {
printk(KERN_INFO "%s: no devices on the port\n", hwif->name);
goto out;
} else if (rc == -EBUSY)
printk(KERN_ERR "%s: not ready before the probe\n", hwif->name);
else
rc = -ENODEV;
if (ide_port_wait_ready(hwif) == -EBUSY)
printk(KERN_DEBUG "%s: Wait for ready failed before probe !\n", hwif->name);

/*
* Second drive should only exist if first drive was found,
Expand All @@ -713,7 +707,7 @@ static int ide_probe_port(ide_hwif_t *hwif)
if (drive->dev_flags & IDE_DFLAG_PRESENT)
rc = 0;
}
out:

/*
* Use cached IRQ number. It might be (and is...) changed by probe
* code above
Expand Down

0 comments on commit 9ce41ae

Please sign in to comment.