Skip to content

Commit

Permalink
tiny: reverse logic for DISABLE_DEV_COREDUMP
Browse files Browse the repository at this point in the history
It's desirable for allnconfig and tinyconfig targets to result in the
least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to
switch off DEV_COREDUMP regardless if any drivers select
WANT_DEV_COREDUMP.

This patch renames the option to ENABLE_DEV_COREDUMP and setting it to
'n' (as in allnconfig or tinyconfig) will effectively disable device
coredump.

Cc: Josh Triplett <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
Signed-off-by: Aristeu Rozanski <[email protected]>
Reviewed-by: Johannes Berg <[email protected]>
Acked-by: Johannes Berg <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
aristeu authored and gregkh committed Nov 7, 2014
1 parent e4a60d1 commit 9c60269
Showing 1 changed file with 11 additions and 8 deletions.
19 changes: 11 additions & 8 deletions drivers/base/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -171,20 +171,23 @@ config WANT_DEV_COREDUMP
Drivers should "select" this option if they desire to use the
device coredump mechanism.

config DISABLE_DEV_COREDUMP
bool "Disable device coredump" if EXPERT
config ENABLE_DEV_COREDUMP
bool "Enable device coredump" if EXPERT
default y
help
Disable the device coredump mechanism despite drivers wanting to
use it; this allows for more sensitive systems or systems that
don't want to ever access the information to not have the code,
nor keep any data.
This option controls if the device coredump mechanism is available or
not; if disabled, the mechanism will be omitted even if drivers that
can use it are enabled.
Say 'N' for more sensitive systems or systems that don't want
to ever access the information to not have the code, nor keep any
data.

If unsure, say N.
If unsure, say Y.

config DEV_COREDUMP
bool
default y if WANT_DEV_COREDUMP
depends on !DISABLE_DEV_COREDUMP
depends on ENABLE_DEV_COREDUMP

config DEBUG_DRIVER
bool "Driver Core verbose debug messages"
Expand Down

0 comments on commit 9c60269

Please sign in to comment.