Skip to content

Commit

Permalink
fs: configfs: Drop unused parameter from configfs_undepend_item()
Browse files Browse the repository at this point in the history
subsys parameter is never used by configfs_undepend_item()
so there is no point in passing it to this function.

Signed-off-by: Krzysztof Opasiak <[email protected]>
Cc: Joel Becker <[email protected]>
Cc: Christoph Hellwig <[email protected]>
Signed-off-by: Nicholas Bellinger <[email protected]>
  • Loading branch information
kopasiak authored and nablio3000 committed Dec 21, 2015
1 parent 2628b35 commit 9a9e341
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion drivers/target/target_core_configfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ EXPORT_SYMBOL(target_depend_item);

void target_undepend_item(struct config_item *item)
{
return configfs_undepend_item(&target_core_fabrics, item);
return configfs_undepend_item(item);
}
EXPORT_SYMBOL(target_undepend_item);

Expand Down
3 changes: 1 addition & 2 deletions fs/configfs/dir.c
Original file line number Diff line number Diff line change
Expand Up @@ -1128,8 +1128,7 @@ EXPORT_SYMBOL(configfs_depend_item);
* configfs_depend_item() because we know that that the client driver is
* pinned, thus the subsystem is pinned, and therefore configfs is pinned.
*/
void configfs_undepend_item(struct configfs_subsystem *subsys,
struct config_item *target)
void configfs_undepend_item(struct config_item *target)
{
struct configfs_dirent *sd;

Expand Down
2 changes: 1 addition & 1 deletion fs/ocfs2/cluster/nodemanager.c
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,7 @@ int o2nm_depend_item(struct config_item *item)

void o2nm_undepend_item(struct config_item *item)
{
configfs_undepend_item(&o2nm_cluster_group.cs_subsys, item);
configfs_undepend_item(item);
}

int o2nm_depend_this_node(void)
Expand Down
5 changes: 3 additions & 2 deletions include/linux/configfs.h
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,8 @@ void configfs_unregister_default_group(struct config_group *group);

/* These functions can sleep and can alloc with GFP_KERNEL */
/* WARNING: These cannot be called underneath configfs callbacks!! */
int configfs_depend_item(struct configfs_subsystem *subsys, struct config_item *target);
void configfs_undepend_item(struct configfs_subsystem *subsys, struct config_item *target);
int configfs_depend_item(struct configfs_subsystem *subsys,
struct config_item *target);
void configfs_undepend_item(struct config_item *target);

#endif /* _CONFIGFS_H_ */

0 comments on commit 9a9e341

Please sign in to comment.