Skip to content

Commit

Permalink
fcntl: rename F_OWNER_GID to F_OWNER_PGRP
Browse files Browse the repository at this point in the history
This is for consistency with various ioctl() operations that include the
suffix "PGRP" in their names, and also for consistency with PRIO_PGRP,
used with setpriority() and getpriority().  Also, using PGRP instead of
GID avoids confusion with the common abbreviation of "group ID".

I'm fine with anything that makes it more consistent, and if PGRP is what
is the predominant abbreviation then I see no need to further confuse
matters by adding a third one.

Signed-off-by: Peter Zijlstra <[email protected]>
Acked-by: Michael Kerrisk <[email protected]>
Cc: Ingo Molnar <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Peter Zijlstra authored and torvalds committed Nov 18, 2009
1 parent 9ebd4eb commit 978b405
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions fs/fcntl.c
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ static int f_setown_ex(struct file *filp, unsigned long arg)
type = PIDTYPE_PID;
break;

case F_OWNER_GID:
case F_OWNER_PGRP:
type = PIDTYPE_PGID;
break;

Expand Down Expand Up @@ -321,7 +321,7 @@ static int f_getown_ex(struct file *filp, unsigned long arg)
break;

case PIDTYPE_PGID:
owner.type = F_OWNER_GID;
owner.type = F_OWNER_PGRP;
break;

default:
Expand Down
2 changes: 1 addition & 1 deletion include/asm-generic/fcntl.h
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@

#define F_OWNER_TID 0
#define F_OWNER_PID 1
#define F_OWNER_GID 2
#define F_OWNER_PGRP 2

struct f_owner_ex {
int type;
Expand Down

0 comments on commit 978b405

Please sign in to comment.