Skip to content

Commit

Permalink
Merge tag 'backlight-next-5.9' of git://git.kernel.org/pub/scm/linux/…
Browse files Browse the repository at this point in the history
…kernel/git/lee/backlight

Pull backlight updates from Lee Jones:
 "Core Framework:
   - Trivial: Code refactoring
   - New API backlight_is_blank()
   - New API backlight_get_brightness()
   - Additional/reworked documentation
   - Remove 'extern' labels from prototypes
   - Drop backlight_put()
   - Staticify of_find_backlight()

  Driver Removal:
   - Removal of unused OT200 driver
   - Removal of unused Generic Backlight driver

  Fix-ups
   - Bunch of W=1 warning fixes
   - Convert to GPIO descriptors; sky81452
   - Move platform data handling into driver; sky81452
   - Remove superfluous code; lms501kf03
   - Many instances of using new APIs"

* tag 'backlight-next-5.9' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight: (34 commits)
  video: backlight: cr_bllcd: Remove unused variable 'intensity'
  backlight: backlight: Make of_find_backlight static
  backlight: backlight: Drop backlight_put()
  backlight: Use backlight_get_brightness() throughout
  backlight: jornada720_bl: Introduce backlight_is_blank()
  backlight: gpio_backlight: Simplify update_status()
  backlight: cr_bllcd: Introduce gpio-backlight semantics
  backlight: as3711_bl: Simplify update_status
  backlight: backlight: Introduce backlight_get_brightness()
  doc-rst: Wire-up Backlight kernel-doc documentation
  backlight: backlight: Add overview and update existing doc
  backlight: backlight: Drop extern from prototypes
  backlight: generic_bl: Remove this driver as it is unused
  backlight: backlight: Document enums in backlight.h
  backlight: backlight: Document inline functions in backlight.h
  backlight: backlight: Improve backlight_device documentation
  backlight: backlight: Improve backlight_properties documentation
  backlight: backlight: Improve backlight_ops documentation
  backlight: backlight: Add backlight_is_blank()
  backlight: backlight: Refactor fb_notifier_callback()
  ...
  • Loading branch information
torvalds committed Aug 11, 2020
2 parents c636eef + 7eb99a3 commit 96f970f
Show file tree
Hide file tree
Showing 39 changed files with 538 additions and 717 deletions.
12 changes: 12 additions & 0 deletions Documentation/gpu/backlight.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
=================
Backlight support
=================

.. kernel-doc:: drivers/video/backlight/backlight.c
:doc: overview

.. kernel-doc:: include/linux/backlight.h
:internal:

.. kernel-doc:: drivers/video/backlight/backlight.c
:export:
1 change: 1 addition & 0 deletions Documentation/gpu/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Linux GPU Driver Developer's Guide
drm-uapi
drm-client
drivers
backlight
vga-switcheroo
vgaarbiter
todo
Expand Down
2 changes: 0 additions & 2 deletions drivers/mfd/sky81452.c
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ static int sky81452_probe(struct i2c_client *client,
memset(cells, 0, sizeof(cells));
cells[0].name = "sky81452-backlight";
cells[0].of_compatible = "skyworks,sky81452-backlight";
cells[0].platform_data = pdata->bl_pdata;
cells[0].pdata_size = sizeof(*pdata->bl_pdata);
cells[1].name = "sky81452-regulator";
cells[1].platform_data = pdata->regulator_init_data;
cells[1].pdata_size = sizeof(*pdata->regulator_init_data);
Expand Down
13 changes: 1 addition & 12 deletions drivers/video/backlight/88pm860x_bl.c
Original file line number Diff line number Diff line change
Expand Up @@ -121,18 +121,7 @@ static int pm860x_backlight_set(struct backlight_device *bl, int brightness)

static int pm860x_backlight_update_status(struct backlight_device *bl)
{
int brightness = bl->props.brightness;

if (bl->props.power != FB_BLANK_UNBLANK)
brightness = 0;

if (bl->props.fb_blank != FB_BLANK_UNBLANK)
brightness = 0;

if (bl->props.state & BL_CORE_SUSPENDED)
brightness = 0;

return pm860x_backlight_set(bl, brightness);
return pm860x_backlight_set(bl, backlight_get_brightness(bl));
}

static int pm860x_backlight_get_brightness(struct backlight_device *bl)
Expand Down
15 changes: 0 additions & 15 deletions drivers/video/backlight/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -173,14 +173,6 @@ config BACKLIGHT_EP93XX
To compile this driver as a module, choose M here: the module will
be called ep93xx_bl.

config BACKLIGHT_GENERIC
tristate "Generic (aka Sharp Corgi) Backlight Driver"
default y
help
Say y to enable the generic platform backlight driver previously
known as the Corgi backlight driver. If you have a Sharp Zaurus
SL-C7xx, SL-Cxx00 or SL-6000x say y.

config BACKLIGHT_IPAQ_MICRO
tristate "iPAQ microcontroller backlight driver"
depends on MFD_IPAQ_MICRO
Expand Down Expand Up @@ -386,13 +378,6 @@ config BACKLIGHT_LP8788
help
This supports TI LP8788 backlight driver.

config BACKLIGHT_OT200
tristate "Backlight driver for ot200 visualisation device"
depends on CS5535_MFGPT && GPIO_CS5535
help
To compile this driver as a module, choose M here: the module will be
called ot200_bl.

config BACKLIGHT_PANDORA
tristate "Backlight driver for Pandora console"
depends on TWL4030_CORE
Expand Down
2 changes: 0 additions & 2 deletions drivers/video/backlight/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ obj-$(CONFIG_BACKLIGHT_CLASS_DEVICE) += backlight.o
obj-$(CONFIG_BACKLIGHT_DA903X) += da903x_bl.o
obj-$(CONFIG_BACKLIGHT_DA9052) += da9052_bl.o
obj-$(CONFIG_BACKLIGHT_EP93XX) += ep93xx_bl.o
obj-$(CONFIG_BACKLIGHT_GENERIC) += generic_bl.o
obj-$(CONFIG_BACKLIGHT_GPIO) += gpio_backlight.o
obj-$(CONFIG_BACKLIGHT_HP680) += hp680_bl.o
obj-$(CONFIG_BACKLIGHT_HP700) += jornada720_bl.o
Expand All @@ -45,7 +44,6 @@ obj-$(CONFIG_BACKLIGHT_LP8788) += lp8788_bl.o
obj-$(CONFIG_BACKLIGHT_LV5207LP) += lv5207lp.o
obj-$(CONFIG_BACKLIGHT_MAX8925) += max8925_bl.o
obj-$(CONFIG_BACKLIGHT_OMAP1) += omap1_bl.o
obj-$(CONFIG_BACKLIGHT_OT200) += ot200_bl.o
obj-$(CONFIG_BACKLIGHT_PANDORA) += pandora_bl.o
obj-$(CONFIG_BACKLIGHT_PCF50633) += pcf50633-backlight.o
obj-$(CONFIG_BACKLIGHT_PWM) += pwm_bl.o
Expand Down
10 changes: 1 addition & 9 deletions drivers/video/backlight/adp5520_bl.c
Original file line number Diff line number Diff line change
Expand Up @@ -65,15 +65,7 @@ static int adp5520_bl_set(struct backlight_device *bl, int brightness)

static int adp5520_bl_update_status(struct backlight_device *bl)
{
int brightness = bl->props.brightness;

if (bl->props.power != FB_BLANK_UNBLANK)
brightness = 0;

if (bl->props.fb_blank != FB_BLANK_UNBLANK)
brightness = 0;

return adp5520_bl_set(bl, brightness);
return adp5520_bl_set(bl, backlight_get_brightness(bl));
}

static int adp5520_bl_get_brightness(struct backlight_device *bl)
Expand Down
10 changes: 1 addition & 9 deletions drivers/video/backlight/adp8860_bl.c
Original file line number Diff line number Diff line change
Expand Up @@ -361,15 +361,7 @@ static int adp8860_bl_set(struct backlight_device *bl, int brightness)

static int adp8860_bl_update_status(struct backlight_device *bl)
{
int brightness = bl->props.brightness;

if (bl->props.power != FB_BLANK_UNBLANK)
brightness = 0;

if (bl->props.fb_blank != FB_BLANK_UNBLANK)
brightness = 0;

return adp8860_bl_set(bl, brightness);
return adp8860_bl_set(bl, backlight_get_brightness(bl));
}

static int adp8860_bl_get_brightness(struct backlight_device *bl)
Expand Down
10 changes: 1 addition & 9 deletions drivers/video/backlight/adp8870_bl.c
Original file line number Diff line number Diff line change
Expand Up @@ -399,15 +399,7 @@ static int adp8870_bl_set(struct backlight_device *bl, int brightness)

static int adp8870_bl_update_status(struct backlight_device *bl)
{
int brightness = bl->props.brightness;

if (bl->props.power != FB_BLANK_UNBLANK)
brightness = 0;

if (bl->props.fb_blank != FB_BLANK_UNBLANK)
brightness = 0;

return adp8870_bl_set(bl, brightness);
return adp8870_bl_set(bl, backlight_get_brightness(bl));
}

static int adp8870_bl_get_brightness(struct backlight_device *bl)
Expand Down
11 changes: 2 additions & 9 deletions drivers/video/backlight/as3711_bl.c
Original file line number Diff line number Diff line change
Expand Up @@ -104,17 +104,10 @@ static int as3711_bl_update_status(struct backlight_device *bl)
struct as3711_bl_data *data = bl_get_data(bl);
struct as3711_bl_supply *supply = to_supply(data);
struct as3711 *as3711 = supply->as3711;
int brightness = bl->props.brightness;
int brightness;
int ret = 0;

dev_dbg(&bl->dev, "%s(): brightness %u, pwr %x, blank %x, state %x\n",
__func__, bl->props.brightness, bl->props.power,
bl->props.fb_blank, bl->props.state);

if (bl->props.power != FB_BLANK_UNBLANK ||
bl->props.fb_blank != FB_BLANK_UNBLANK ||
bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
brightness = 0;
brightness = backlight_get_brightness(bl);

if (data->type == AS3711_BL_SU1) {
ret = as3711_set_brightness_v(as3711, brightness,
Expand Down
Loading

0 comments on commit 96f970f

Please sign in to comment.