Skip to content

Commit

Permalink
powerpc/ps3: Remove an unneeded NULL check
Browse files Browse the repository at this point in the history
Static checkers don't like the inconsistent NULL checking on "ops".
This function is only called once and "ops" isn't NULL so the check
can be removed.

Signed-off-by: Dan Carpenter <[email protected]>
Signed-off-by: Geoff Levand <[email protected]>
Signed-off-by: Michael Ellerman <[email protected]>
Link: https://lore.kernel.org/r/ddc3513dc54d15456692c80df49287fe3babe40a.1585340156.git.geoff@infradead.org
  • Loading branch information
Dan Carpenter authored and mpe committed Apr 2, 2020
1 parent 7ee4174 commit 96efbab
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/ps3/sys-manager-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ void ps3_sys_manager_register_ops(const struct ps3_sys_manager_ops *ops)
{
BUG_ON(!ops);
BUG_ON(!ops->dev);
ps3_sys_manager_ops = ops ? *ops : ps3_sys_manager_ops;
ps3_sys_manager_ops = *ops;
}
EXPORT_SYMBOL_GPL(ps3_sys_manager_register_ops);

Expand Down

0 comments on commit 96efbab

Please sign in to comment.