cachefiles: Handle readpage error correctly

If ->readpage returns an error, it has already unlocked the page. Fixes: 5e929b3 ("CacheFiles: Handle truncate unlocking the page we're reading") Cc: [email protected] Signed-off-by: Matthew Wilcox (Oracle) <[email protected]> Signed-off-by: David Howells <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
chewitt · Oct 26, 2020 · 9480b4e · 9480b4e
1 parent 7e2b2da
commit 9480b4e
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/fs/cachefiles/rdwr.c b/fs/cachefiles/rdwr.c
@@ -121,7 +121,7 @@ static int cachefiles_read_reissue(struct cachefiles_object *object,
 		_debug("reissue read");
 		ret = bmapping->a_ops->readpage(NULL, backpage);
 		if (ret < 0)
-			goto unlock_discard;
+			goto discard;
 	}
 
 	/* but the page may have been read before the monitor was installed, so
@@ -138,6 +138,7 @@ static int cachefiles_read_reissue(struct cachefiles_object *object,
 
 unlock_discard:
 	unlock_page(backpage);
+discard:
 	spin_lock_irq(&object->work_lock);
 	list_del(&monitor->op_link);
 	spin_unlock_irq(&object->work_lock);