Skip to content

Commit

Permalink
[BRIDGE]: don't change packet type
Browse files Browse the repository at this point in the history
The change to forward STP bpdu's (for usermode STP) through normal path,
changed the packet type in the process. Since link local stuff is multicast, it
should stay pkt_type = PACKET_MULTICAST.  The code was probably copy/pasted
incorrectly from the bridge pseudo-device receive path.

Signed-off-by: Stephen Hemminger <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Stephen Hemminger authored and David S. Miller committed Apr 26, 2007
1 parent e1ec784 commit 83aa093
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions net/bridge/br_input.c
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,9 @@ struct sk_buff *br_handle_frame(struct net_bridge_port *p, struct sk_buff *skb)
if (!is_valid_ether_addr(eth_hdr(skb)->h_source))
goto drop;

if (unlikely(is_link_local(dest))) {
skb->pkt_type = PACKET_HOST;

if (unlikely(is_link_local(dest)))
return (NF_HOOK(PF_BRIDGE, NF_BR_LOCAL_IN, skb, skb->dev,
NULL, br_handle_local_finish) == 0) ? skb : NULL;
}

switch (p->state) {
case BR_STATE_FORWARDING:
Expand Down

0 comments on commit 83aa093

Please sign in to comment.