Skip to content

Commit

Permalink
video: fbdev: omapfb: panel-sharp-ls037v7dw01: Make use of the helper…
Browse files Browse the repository at this point in the history
… function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <[email protected]>
Signed-off-by: Helge Deller <[email protected]>
  • Loading branch information
caihuoqing1990 authored and hdeller committed Jan 29, 2022
1 parent 9d773f1 commit 7ebf85c
Showing 1 changed file with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,9 @@ static int sharp_ls_probe_of(struct platform_device *pdev)
int r;

ddata->vcc = devm_regulator_get(&pdev->dev, "envdd");
if (IS_ERR(ddata->vcc)) {
dev_err(&pdev->dev, "failed to get regulator\n");
return PTR_ERR(ddata->vcc);
}
if (IS_ERR(ddata->vcc))
return dev_err_probe(&pdev->dev, PTR_ERR(ddata->vcc),
"failed to get regulator\n");

/* lcd INI */
r = sharp_ls_get_gpio_of(&pdev->dev, 0, 0, "enable", &ddata->ini_gpio);
Expand Down

0 comments on commit 7ebf85c

Please sign in to comment.