forked from torvalds/linux
-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Check for opencoded swap() implementation. Signed-off-by: Denis Efremov <[email protected]> Signed-off-by: Julia Lawall <[email protected]>
- Loading branch information
1 parent
cb62732
commit 7845daa
Showing
1 changed file
with
122 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| // SPDX-License-Identifier: GPL-2.0-only | ||
| /// | ||
| /// Check for opencoded swap() implementation. | ||
| /// | ||
| // Confidence: High | ||
| // Copyright: (C) 2021 Denis Efremov ISPRAS | ||
| // Options: --no-includes --include-headers | ||
| // | ||
| // Keywords: swap | ||
| // | ||
|
|
||
| virtual patch | ||
| virtual org | ||
| virtual report | ||
| virtual context | ||
|
|
||
| @rvar depends on !patch@ | ||
| identifier tmp; | ||
| expression a, b; | ||
| type T; | ||
| position p; | ||
| @@ | ||
|
|
||
| ( | ||
| * T tmp; | ||
| | | ||
| * T tmp = 0; | ||
| | | ||
| * T *tmp = NULL; | ||
| ) | ||
| ... when != tmp | ||
| * tmp = a; | ||
| * a = b;@p | ||
| * b = tmp; | ||
| ... when != tmp | ||
|
|
||
| @r depends on !patch@ | ||
| identifier tmp; | ||
| expression a, b; | ||
| position p != rvar.p; | ||
| @@ | ||
|
|
||
| * tmp = a; | ||
| * a = b;@p | ||
| * b = tmp; | ||
|
|
||
| @rpvar depends on patch@ | ||
| identifier tmp; | ||
| expression a, b; | ||
| type T; | ||
| @@ | ||
|
|
||
| ( | ||
| - T tmp; | ||
| | | ||
| - T tmp = 0; | ||
| | | ||
| - T *tmp = NULL; | ||
| ) | ||
| ... when != tmp | ||
| - tmp = a; | ||
| - a = b; | ||
| - b = tmp | ||
| + swap(a, b) | ||
| ; | ||
| ... when != tmp | ||
|
|
||
| @rp depends on patch@ | ||
| identifier tmp; | ||
| expression a, b; | ||
| @@ | ||
|
|
||
| - tmp = a; | ||
| - a = b; | ||
| - b = tmp | ||
| + swap(a, b) | ||
| ; | ||
|
|
||
| @depends on patch && (rpvar || rp)@ | ||
| @@ | ||
|
|
||
| ( | ||
| for (...;...;...) | ||
| - { | ||
| swap(...); | ||
| - } | ||
| | | ||
| while (...) | ||
| - { | ||
| swap(...); | ||
| - } | ||
| | | ||
| if (...) | ||
| - { | ||
| swap(...); | ||
| - } | ||
| ) | ||
|
|
||
|
|
||
| @script:python depends on report@ | ||
| p << r.p; | ||
| @@ | ||
| coccilib.report.print_report(p[0], "WARNING opportunity for swap()") | ||
| @script:python depends on org@ | ||
| p << r.p; | ||
| @@ | ||
| coccilib.org.print_todo(p[0], "WARNING opportunity for swap()") | ||
| @script:python depends on report@ | ||
| p << rvar.p; | ||
| @@ | ||
| coccilib.report.print_report(p[0], "WARNING opportunity for swap()") | ||
| @script:python depends on org@ | ||
| p << rvar.p; | ||
| @@ | ||
| coccilib.org.print_todo(p[0], "WARNING opportunity for swap()") |