EDAC: Delete unnecessary checks before pci_dev_put()

The pci_dev_put() function tests whether its argument is NULL and thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Borislav Petkov <[email protected]>
chewitt · Feb 23, 2015 · 7260194 · 7260194
1 parent c517d83
commit 7260194
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 16 deletions.
diff --git a/drivers/edac/i82443bxgx_edac.c b/drivers/edac/i82443bxgx_edac.c
@@ -445,9 +445,7 @@ static int __init i82443bxgx_edacmc_init(void)
 	pci_unregister_driver(&i82443bxgx_edacmc_driver);
 
 fail0:
-	if (mci_pdev != NULL)
-		pci_dev_put(mci_pdev);
-
+	pci_dev_put(mci_pdev);
 	return pci_rc;
 }
 

diff --git a/drivers/edac/i82860_edac.c b/drivers/edac/i82860_edac.c
@@ -343,20 +343,15 @@ static int __init i82860_init(void)
 	pci_unregister_driver(&i82860_driver);
 
 fail0:
-	if (mci_pdev != NULL)
-		pci_dev_put(mci_pdev);
-
+	pci_dev_put(mci_pdev);
 	return pci_rc;
 }
 
 static void __exit i82860_exit(void)
 {
 	edac_dbg(3, "\n");
-
 	pci_unregister_driver(&i82860_driver);
-
-	if (mci_pdev != NULL)
-		pci_dev_put(mci_pdev);
+	pci_dev_put(mci_pdev);
 }
 
 module_init(i82860_init);

diff --git a/drivers/edac/i82875p_edac.c b/drivers/edac/i82875p_edac.c
@@ -576,9 +576,7 @@ static int __init i82875p_init(void)
 	pci_unregister_driver(&i82875p_driver);
 
 fail0:
-	if (mci_pdev != NULL)
-		pci_dev_put(mci_pdev);
-
+	pci_dev_put(mci_pdev);
 	return pci_rc;
 }
 

diff --git a/drivers/edac/i82975x_edac.c b/drivers/edac/i82975x_edac.c
@@ -685,9 +685,7 @@ static int __init i82975x_init(void)
 	pci_unregister_driver(&i82975x_driver);
 
 fail0:
-	if (mci_pdev != NULL)
-		pci_dev_put(mci_pdev);
-
+	pci_dev_put(mci_pdev);
 	return pci_rc;
 }