Skip to content

Commit

Permalink
mfd: max8997: Simplify obtaining I2C match data and drop max8997_i2c_…
Browse files Browse the repository at this point in the history
…get_driver_data()

Simplify probe() by using i2c_get_match_data() instead of
max8997_i2c_get_driver_data() for retrieving match data from
OF/ID tables.

Signed-off-by: Biju Das <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Lee Jones <[email protected]>
  • Loading branch information
Biju Das authored and lag-linaro committed Nov 1, 2023
1 parent 3c70342 commit 676c267
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions drivers/mfd/max8997.c
Original file line number Diff line number Diff line change
Expand Up @@ -142,18 +142,8 @@ static struct max8997_platform_data *max8997_i2c_parse_dt_pdata(
return pd;
}

static inline unsigned long max8997_i2c_get_driver_data(struct i2c_client *i2c,
const struct i2c_device_id *id)
{
if (i2c->dev.of_node)
return (unsigned long)of_device_get_match_data(&i2c->dev);

return id->driver_data;
}

static int max8997_i2c_probe(struct i2c_client *i2c)
{
const struct i2c_device_id *id = i2c_client_get_device_id(i2c);
struct max8997_dev *max8997;
struct max8997_platform_data *pdata = dev_get_platdata(&i2c->dev);
int ret = 0;
Expand All @@ -166,7 +156,7 @@ static int max8997_i2c_probe(struct i2c_client *i2c)
i2c_set_clientdata(i2c, max8997);
max8997->dev = &i2c->dev;
max8997->i2c = i2c;
max8997->type = max8997_i2c_get_driver_data(i2c, id);
max8997->type = (uintptr_t)i2c_get_match_data(i2c);
max8997->irq = i2c->irq;

if (IS_ENABLED(CONFIG_OF) && max8997->dev->of_node) {
Expand Down

0 comments on commit 676c267

Please sign in to comment.