Skip to content

Commit

Permalink
[MTD] mtdoops: Use the panic_write function when present
Browse files Browse the repository at this point in the history
When the MTD provides a panic_write function, use it.

Signed-off-by: Richard Purdie <[email protected]>
Signed-off-by: David Woodhouse <[email protected]>
  • Loading branch information
rpurdie authored and dwmw2 committed Feb 7, 2008
1 parent 388bbb0 commit 621e4f8
Showing 1 changed file with 21 additions and 5 deletions.
26 changes: 21 additions & 5 deletions drivers/mtd/mtdoops.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include <linux/workqueue.h>
#include <linux/sched.h>
#include <linux/wait.h>
#include <linux/delay.h>
#include <linux/spinlock.h>
#include <linux/mtd/mtd.h>

Expand Down Expand Up @@ -183,10 +184,8 @@ static void mtdoops_workfunc_erase(struct work_struct *work)
goto badblock;
}

static void mtdoops_workfunc_write(struct work_struct *work)
static void mtdoops_write(struct mtdoops_context *cxt, int panic)
{
struct mtdoops_context *cxt =
container_of(work, struct mtdoops_context, work_write);
struct mtd_info *mtd = cxt->mtd;
size_t retlen;
int ret;
Expand All @@ -195,7 +194,11 @@ static void mtdoops_workfunc_write(struct work_struct *work)
memset(cxt->oops_buf + cxt->writecount, 0xff,
OOPS_PAGE_SIZE - cxt->writecount);

ret = mtd->write(mtd, cxt->nextpage * OOPS_PAGE_SIZE,
if (panic)
ret = mtd->panic_write(mtd, cxt->nextpage * OOPS_PAGE_SIZE,
OOPS_PAGE_SIZE, &retlen, cxt->oops_buf);
else
ret = mtd->write(mtd, cxt->nextpage * OOPS_PAGE_SIZE,
OOPS_PAGE_SIZE, &retlen, cxt->oops_buf);

cxt->writecount = 0;
Expand All @@ -205,6 +208,15 @@ static void mtdoops_workfunc_write(struct work_struct *work)
cxt->nextpage * OOPS_PAGE_SIZE, retlen, OOPS_PAGE_SIZE, ret);

mtdoops_inc_counter(cxt);
}


static void mtdoops_workfunc_write(struct work_struct *work)
{
struct mtdoops_context *cxt =
container_of(work, struct mtdoops_context, work_write);

mtdoops_write(cxt, 0);
}

static void find_next_position(struct mtdoops_context *cxt)
Expand Down Expand Up @@ -314,7 +326,11 @@ static void mtdoops_console_sync(void)
cxt->ready = 0;
spin_unlock_irqrestore(&cxt->writecount_lock, flags);

schedule_work(&cxt->work_write);
if (mtd->panic_write && in_interrupt())
/* Interrupt context, we're going to panic so try and log */
mtdoops_write(cxt, 1);
else
schedule_work(&cxt->work_write);
}

static void
Expand Down

0 comments on commit 621e4f8

Please sign in to comment.