Skip to content

Commit

Permalink
orangefs: Use kcalloc() in orangefs_prepare_cdm_array()
Browse files Browse the repository at this point in the history
* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kcalloc".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data structure by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <[email protected]>
Signed-off-by: Mike Marshall <[email protected]>
  • Loading branch information
elfring authored and hubcapsc committed Sep 14, 2017
1 parent 07a2585 commit 5e273a0
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions fs/orangefs/orangefs-debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -571,9 +571,7 @@ static int orangefs_prepare_cdm_array(char *debug_array_string)
goto out;
}

cdm_array =
kzalloc(cdm_element_count * sizeof(struct client_debug_mask),
GFP_KERNEL);
cdm_array = kcalloc(cdm_element_count, sizeof(*cdm_array), GFP_KERNEL);
if (!cdm_array) {
rc = -ENOMEM;
goto out;
Expand Down

0 comments on commit 5e273a0

Please sign in to comment.