Skip to content

Commit

Permalink
vt: remove superfluous CONFIG_HW_CONSOLE
Browse files Browse the repository at this point in the history
The config HW_CONSOLE is always identical to the config VT and is not
visible in the kernel's build menuconfig. So, CONFIG_HW_CONSOLE is
redundant.

Replace all references to CONFIG_HW_CONSOLE with CONFIG_VT and remove
CONFIG_HW_CONSOLE.

Signed-off-by: Lukas Bulwahn <[email protected]>
Reviewed-by: Javier Martinez Canillas <[email protected]>
Acked-by: Dmitry Torokhov <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]>
Acked-by: Geert Uytterhoeven <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
bulwahn authored and gregkh committed Jan 28, 2024
1 parent 9e957a1 commit 5c49b6a
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 15 deletions.
2 changes: 1 addition & 1 deletion arch/m68k/amiga/config.c
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,6 @@ static void amiga_get_hardware_list(struct seq_file *m)
* The Amiga keyboard driver needs key_maps, but we cannot export it in
* drivers/char/defkeymap.c, as it is autogenerated
*/
#ifdef CONFIG_HW_CONSOLE
#ifdef CONFIG_VT
EXPORT_SYMBOL_GPL(key_maps);
#endif
6 changes: 3 additions & 3 deletions drivers/input/keyboard/amikbd.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ MODULE_AUTHOR("Vojtech Pavlik <[email protected]>");
MODULE_DESCRIPTION("Amiga keyboard driver");
MODULE_LICENSE("GPL");

#ifdef CONFIG_HW_CONSOLE
#ifdef CONFIG_VT
static unsigned char amikbd_keycode[0x78] __initdata = {
[0] = KEY_GRAVE,
[1] = KEY_1,
Expand Down Expand Up @@ -148,9 +148,9 @@ static void __init amikbd_init_console_keymaps(void)
memcpy(key_maps[i], temp_map, sizeof(temp_map));
}
}
#else /* !CONFIG_HW_CONSOLE */
#else /* !CONFIG_VT */
static inline void amikbd_init_console_keymaps(void) {}
#endif /* !CONFIG_HW_CONSOLE */
#endif /* !CONFIG_VT */

static const char *amikbd_messages[8] = {
[0] = KERN_ALERT "amikbd: Ctrl-Amiga-Amiga reset warning!!\n",
Expand Down
7 changes: 1 addition & 6 deletions drivers/tty/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,9 @@ config VT_CONSOLE_SLEEP
def_bool y
depends on VT_CONSOLE && PM_SLEEP

config HW_CONSOLE
bool
depends on VT
default y

config VT_HW_CONSOLE_BINDING
bool "Support for binding and unbinding console drivers"
depends on HW_CONSOLE
depends on VT
help
The virtual terminal is the device that interacts with the physical
terminal through console drivers. On these systems, at least one
Expand Down
4 changes: 2 additions & 2 deletions drivers/tty/vt/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
FONTMAPFILE = cp437.uni

obj-$(CONFIG_VT) += vt_ioctl.o vc_screen.o \
selection.o keyboard.o
selection.o keyboard.o \
vt.o defkeymap.o
obj-$(CONFIG_CONSOLE_TRANSLATIONS) += consolemap.o consolemap_deftbl.o
obj-$(CONFIG_HW_CONSOLE) += vt.o defkeymap.o

# Files generated that shall be removed upon make clean
clean-files := consolemap_deftbl.c defkeymap.c
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/fbdev/tgafb.c
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ tgafb_set_par(struct fb_info *info)
BT463_LOAD_ADDR(par, 0x0000);
TGA_WRITE_REG(par, BT463_PALETTE << 2, TGA_RAMDAC_SETUP_REG);

#ifdef CONFIG_HW_CONSOLE
#ifdef CONFIG_VT
for (i = 0; i < 16; i++) {
int j = color_table[i];

Expand Down
2 changes: 1 addition & 1 deletion include/linux/console.h
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ int con_is_bound(const struct consw *csw);
int do_unregister_con_driver(const struct consw *csw);
int do_take_over_console(const struct consw *sw, int first, int last, int deflt);
void give_up_console(const struct consw *sw);
#ifdef CONFIG_HW_CONSOLE
#ifdef CONFIG_VT
void con_debug_enter(struct vc_data *vc);
void con_debug_leave(void);
#else
Expand Down
2 changes: 1 addition & 1 deletion lib/Kconfig.kgdb
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ config KGDB_SERIAL_CONSOLE
tristate "KGDB: use kgdb over the serial console"
select CONSOLE_POLL
select MAGIC_SYSRQ
depends on TTY && HW_CONSOLE
depends on TTY && VT
default y
help
Share a serial console with kgdb. Sysrq-g must be used
Expand Down

0 comments on commit 5c49b6a

Please sign in to comment.