Skip to content

Commit

Permalink
phy: rockchip-inno-usb2: Do not lock in bvalid IRQ handler
Browse files Browse the repository at this point in the history
Clearing the IRQ is atomic, so there is no need to hold the mutex.

Signed-off-by: Samuel Holland <[email protected]>
Tested-by: Michael Riesch <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Vinod Koul <[email protected]>
  • Loading branch information
smaeul authored and vinodkoul committed Apr 20, 2022
1 parent 656f7fc commit 5a709a4
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/phy/rockchip/phy-rockchip-inno-usb2.c
Original file line number Diff line number Diff line change
Expand Up @@ -905,13 +905,9 @@ static irqreturn_t rockchip_usb2phy_bvalid_irq(int irq, void *data)
if (!property_enabled(rphy->grf, &rport->port_cfg->bvalid_det_st))
return IRQ_NONE;

mutex_lock(&rport->mutex);

/* clear bvalid detect irq pending status */
property_enable(rphy->grf, &rport->port_cfg->bvalid_det_clr, true);

mutex_unlock(&rport->mutex);

rockchip_usb2phy_otg_sm_work(&rport->otg_sm_work.work);

return IRQ_HANDLED;
Expand Down

0 comments on commit 5a709a4

Please sign in to comment.