Skip to content

Commit

Permalink
[MACVLAN]: Remove unnecessary IFF_UP check
Browse files Browse the repository at this point in the history
Only devices that are UP are in the hash, so macvlan_broadcast() doesn't
need to check for IFF_UP.

Signed-off-by: Patrick McHardy <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
kaber authored and davem330 committed Jan 28, 2008
1 parent 1b0b04f commit 59891d5
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/macvlan.c
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ static void macvlan_broadcast(struct sk_buff *skb,
for (i = 0; i < MACVLAN_HASH_SIZE; i++) {
hlist_for_each_entry_rcu(vlan, n, &port->vlan_hash[i], hlist) {
dev = vlan->dev;
if (unlikely(!(dev->flags & IFF_UP)))
continue;

nskb = skb_clone(skb, GFP_ATOMIC);
if (nskb == NULL) {
Expand Down

0 comments on commit 59891d5

Please sign in to comment.