Skip to content

Commit

Permalink
mn10300/CPU hotplug: Add missing call to notify_cpu_starting()
Browse files Browse the repository at this point in the history
The scheduler depends on receiving the CPU_STARTING notification, without
which we end up into a lot of trouble. So add the missing call to
notify_cpu_starting() in the bringup code.

Signed-off-by: Srivatsa S. Bhat <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Srivatsa S. Bhat authored and torvalds committed May 16, 2012
1 parent ec2e0f9 commit 568b445
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions arch/mn10300/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include <linux/sched.h>
#include <linux/profile.h>
#include <linux/smp.h>
#include <linux/cpu.h>
#include <asm/tlbflush.h>
#include <asm/bitops.h>
#include <asm/processor.h>
Expand All @@ -38,7 +39,6 @@
#include "internal.h"

#ifdef CONFIG_HOTPLUG_CPU
#include <linux/cpu.h>
#include <asm/cacheflush.h>

static unsigned long sleep_mode[NR_CPUS];
Expand Down Expand Up @@ -874,10 +874,13 @@ static void __init smp_online(void)

cpu = smp_processor_id();

local_irq_enable();
notify_cpu_starting(cpu);

ipi_call_lock();
set_cpu_online(cpu, true);
smp_wmb();
ipi_call_unlock();

local_irq_enable();
}

/**
Expand Down

0 comments on commit 568b445

Please sign in to comment.