Skip to content

Commit

Permalink
mm/vmalloc.c: convert vmap_lazy_nr to atomic_long_t
Browse files Browse the repository at this point in the history
vmap_lazy_nr variable has atomic_t type that is 4 bytes integer value on
both 32 and 64 bit systems.  lazy_max_pages() deals with "unsigned long"
that is 8 bytes on 64 bit system, thus vmap_lazy_nr should be 8 bytes on
64 bit as well.

Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Uladzislau Rezki (Sony) <[email protected]>
Reviewed-by: Andrew Morton <[email protected]>
Reviewed-by: William Kucharski <[email protected]>
Cc: Michal Hocko <[email protected]>
Cc: Matthew Wilcox <[email protected]>
Cc: Thomas Garnier <[email protected]>
Cc: Oleksiy Avramchenko <[email protected]>
Cc: Joel Fernandes <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
urezki authored and torvalds committed May 15, 2019
1 parent 68571be commit 4d36e6f
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions mm/vmalloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ static unsigned long lazy_max_pages(void)
return log * (32UL * 1024 * 1024 / PAGE_SIZE);
}

static atomic_t vmap_lazy_nr = ATOMIC_INIT(0);
static atomic_long_t vmap_lazy_nr = ATOMIC_LONG_INIT(0);

/*
* Serialize vmap purging. There is no actual criticial section protected
Expand All @@ -651,18 +651,18 @@ static void purge_fragmented_blocks_allcpus(void);
*/
void set_iounmap_nonlazy(void)
{
atomic_set(&vmap_lazy_nr, lazy_max_pages()+1);
atomic_long_set(&vmap_lazy_nr, lazy_max_pages()+1);
}

/*
* Purges all lazily-freed vmap areas.
*/
static bool __purge_vmap_area_lazy(unsigned long start, unsigned long end)
{
unsigned long resched_threshold;
struct llist_node *valist;
struct vmap_area *va;
struct vmap_area *n_va;
int resched_threshold;

lockdep_assert_held(&vmap_purge_lock);

Expand All @@ -682,16 +682,16 @@ static bool __purge_vmap_area_lazy(unsigned long start, unsigned long end)
}

flush_tlb_kernel_range(start, end);
resched_threshold = (int) lazy_max_pages() << 1;
resched_threshold = lazy_max_pages() << 1;

spin_lock(&vmap_area_lock);
llist_for_each_entry_safe(va, n_va, valist, purge_list) {
int nr = (va->va_end - va->va_start) >> PAGE_SHIFT;
unsigned long nr = (va->va_end - va->va_start) >> PAGE_SHIFT;

__free_vmap_area(va);
atomic_sub(nr, &vmap_lazy_nr);
atomic_long_sub(nr, &vmap_lazy_nr);

if (atomic_read(&vmap_lazy_nr) < resched_threshold)
if (atomic_long_read(&vmap_lazy_nr) < resched_threshold)
cond_resched_lock(&vmap_area_lock);
}
spin_unlock(&vmap_area_lock);
Expand Down Expand Up @@ -728,10 +728,10 @@ static void purge_vmap_area_lazy(void)
*/
static void free_vmap_area_noflush(struct vmap_area *va)
{
int nr_lazy;
unsigned long nr_lazy;

nr_lazy = atomic_add_return((va->va_end - va->va_start) >> PAGE_SHIFT,
&vmap_lazy_nr);
nr_lazy = atomic_long_add_return((va->va_end - va->va_start) >>
PAGE_SHIFT, &vmap_lazy_nr);

/* After this point, we may free va at any time */
llist_add(&va->purge_list, &vmap_purge_list);
Expand Down

0 comments on commit 4d36e6f

Please sign in to comment.