Skip to content

Commit

Permalink
md/raid0: fix bug with chunksize not a power of 2.
Browse files Browse the repository at this point in the history
Since commit 20d0189
in v3.14-rc1 RAID0 has performed incorrect calculations
when the chunksize is not a power of 2.

This happens because "sector_div()" modifies its first argument, but
this wasn't taken into account in the patch.

So restore that first arg before re-using the variable.

Reported-by: Joe Landman <[email protected]>
Reported-by: Dave Chinner <[email protected]>
Fixes: 20d0189
Cc: [email protected] (3.14 and later).
Signed-off-by: NeilBrown <[email protected]>
  • Loading branch information
neilbrown committed Apr 10, 2015
1 parent 74672d0 commit 47d6897
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/md/raid0.c
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ static struct strip_zone *find_zone(struct r0conf *conf,

/*
* remaps the bio to the target device. we separate two flows.
* power 2 flow and a general flow for the sake of perfromance
* power 2 flow and a general flow for the sake of performance
*/
static struct md_rdev *map_sector(struct mddev *mddev, struct strip_zone *zone,
sector_t sector, sector_t *sector_offset)
Expand Down Expand Up @@ -524,6 +524,7 @@ static void raid0_make_request(struct mddev *mddev, struct bio *bio)
split = bio;
}

sector = bio->bi_iter.bi_sector;
zone = find_zone(mddev->private, &sector);
tmp_dev = map_sector(mddev, zone, sector, &sector);
split->bi_bdev = tmp_dev->bdev;
Expand Down

0 comments on commit 47d6897

Please sign in to comment.