Skip to content

Commit

Permalink
sound: mpu401.c: make return of 0 explicit
Browse files Browse the repository at this point in the history
Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.

A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
local idexpression ret;
expression e;
position p;
@@

-ret = 0;
... when != ret = e
return
- ret
+ 0
  ;
// </smpl>

Signed-off-by: Julia Lawall <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
JuliaLawall authored and tiwai committed May 19, 2014
1 parent d576422 commit 47c9807
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions sound/oss/mpu401.c
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,6 @@ static int mpu401_out(int dev, unsigned char midi_byte)
static int mpu401_command(int dev, mpu_command_rec * cmd)
{
int i, timeout, ok;
int ret = 0;
unsigned long flags;
struct mpu_config *devc;

Expand Down Expand Up @@ -644,7 +643,6 @@ static int mpu401_command(int dev, mpu_command_rec * cmd)
}
}
}
ret = 0;
cmd->data[0] = 0;

if (cmd->nr_returns)
Expand All @@ -666,7 +664,7 @@ static int mpu401_command(int dev, mpu_command_rec * cmd)
}
}
spin_unlock_irqrestore(&devc->lock,flags);
return ret;
return 0;
}

static int mpu_cmd(int dev, int cmd, int data)
Expand Down

0 comments on commit 47c9807

Please sign in to comment.