Skip to content

Commit

Permalink
net: eth: altera: fix napi poll_list corruption
Browse files Browse the repository at this point in the history
tse_poll() calls __napi_complete() with irq enabled.  This leads napi
poll_list corruption and may stop all napi drivers working.
Use napi_complete() instead of __napi_complete().

Signed-off-by: Atsushi Nemoto <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Atsushi Nemoto authored and davem330 committed Sep 3, 2015
1 parent dd5cdb4 commit 4548a69
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/net/ethernet/altera/altera_tse_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -511,8 +511,7 @@ static int tse_poll(struct napi_struct *napi, int budget)

if (rxcomplete < budget) {

napi_gro_flush(napi, false);
__napi_complete(napi);
napi_complete(napi);

netdev_dbg(priv->dev,
"NAPI Complete, did %d packets with budget %d\n",
Expand Down

0 comments on commit 4548a69

Please sign in to comment.