Skip to content

Commit

Permalink
dcbnl: unlock on an error path in dcbnl_cee_fill()
Browse files Browse the repository at this point in the history
We need to release "dcb_lock" which we took on the previous line.

Signed-off-by: Dan Carpenter <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
error27 authored and davem330 committed Jul 8, 2011
1 parent 560040b commit 40f5d72
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/dcb/dcbnl.c
Original file line number Diff line number Diff line change
Expand Up @@ -1409,7 +1409,7 @@ static int dcbnl_cee_fill(struct sk_buff *skb, struct net_device *netdev)
spin_lock(&dcb_lock);
app = nla_nest_start(skb, DCB_ATTR_CEE_APP_TABLE);
if (!app)
goto nla_put_failure;
goto dcb_unlock;

list_for_each_entry(itr, &dcb_app_list, list) {
if (strncmp(itr->name, netdev->name, IFNAMSIZ) == 0) {
Expand Down

0 comments on commit 40f5d72

Please sign in to comment.