Skip to content

Commit

Permalink
hwmon: (coretemp) Properly label the sensors
Browse files Browse the repository at this point in the history
Don't assume that CPU entry number and core ID always match. It
worked in the simple cases (single CPU, no HT) but fails on
multi-CPU systems.

Signed-off-by: Jean Delvare <[email protected]>
Acked-by: Huaxu Wan <[email protected]>
Cc: [email protected]
  • Loading branch information
Jean Delvare committed Jul 9, 2010
1 parent d883b9f commit 3f4f09b
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/hwmon/coretemp.c
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ struct coretemp_data {
struct mutex update_lock;
const char *name;
u32 id;
u16 core_id;
char valid; /* zero until following fields are valid */
unsigned long last_updated; /* in jiffies */
int temp;
Expand All @@ -75,7 +76,7 @@ static ssize_t show_name(struct device *dev, struct device_attribute
if (attr->index == SHOW_NAME)
ret = sprintf(buf, "%s\n", data->name);
else /* show label */
ret = sprintf(buf, "Core %d\n", data->id);
ret = sprintf(buf, "Core %d\n", data->core_id);
return ret;
}

Expand Down Expand Up @@ -304,6 +305,9 @@ static int __devinit coretemp_probe(struct platform_device *pdev)
}

data->id = pdev->id;
#ifdef CONFIG_SMP
data->core_id = c->cpu_core_id;
#endif
data->name = "coretemp";
mutex_init(&data->update_lock);

Expand Down

0 comments on commit 3f4f09b

Please sign in to comment.