Skip to content

Commit

Permalink
ieee1394: ohci1394: switch on bus power after resume on PPC PMac
Browse files Browse the repository at this point in the history
The platform feature calls in the suspend method switched off cable
power, but the calls in the resume method did not switch it back on.

Add the necessary feature call to .resume.  Also add the corresponding
call to .suspend to make .suspend's behavior explicitly the same on all
PMacs.

Signed-off-by: Stefan Richter <[email protected]>
  • Loading branch information
Stefan Richter committed Apr 18, 2008
1 parent d2ace29 commit 38275ac
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions drivers/ieee1394/ohci1394.c
Original file line number Diff line number Diff line change
Expand Up @@ -3340,8 +3340,10 @@ static int ohci1394_pci_suspend(struct pci_dev *pdev, pm_message_t state)
if (machine_is(powermac)) {
struct device_node *ofn = pci_device_to_OF_node(pdev);

if (ofn)
if (ofn) {
pmac_call_feature(PMAC_FTR_1394_ENABLE, ofn, 0, 0);
pmac_call_feature(PMAC_FTR_1394_CABLE_POWER, ofn, 0, 0);
}
}
#endif /* CONFIG_PPC_PMAC */

Expand All @@ -3365,8 +3367,10 @@ static int ohci1394_pci_resume(struct pci_dev *pdev)
if (machine_is(powermac)) {
struct device_node *ofn = pci_device_to_OF_node(pdev);

if (ofn)
if (ofn) {
pmac_call_feature(PMAC_FTR_1394_CABLE_POWER, ofn, 0, 1);
pmac_call_feature(PMAC_FTR_1394_ENABLE, ofn, 0, 1);
}
}
#endif /* CONFIG_PPC_PMAC */

Expand Down

0 comments on commit 38275ac

Please sign in to comment.