Skip to content

Commit

Permalink
mISDN: fix misuse of put_device() in mISDN_register_device()
Browse files Browse the repository at this point in the history
We should not release reference by put_device() before calling device_initialize().

Fixes: e7d1d4d ("mISDN: fix possible memory leak in mISDN_register_device()")
Signed-off-by: Wang ShaoBo <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Wang ShaoBo authored and davem330 committed Nov 14, 2022
1 parent 8979f42 commit 2d25107
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/isdn/mISDN/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ mISDN_register_device(struct mISDNdevice *dev,

err = get_free_devid();
if (err < 0)
goto error1;
return err;
dev->id = err;

device_initialize(&dev->dev);
Expand Down

0 comments on commit 2d25107

Please sign in to comment.