Skip to content

Commit

Permalink
Remove get_init_pts_sb()
Browse files Browse the repository at this point in the history
With mknod_ptmx() moved to devpts_get_sb(), init_pts_mount() becomes
a wrapper around get_init_pts_sb(). Remove get_init_pts_sb() and
fold code into init_pts_mount().

Signed-off-by: Sukadev Bhattiprolu <[email protected]>
Acked-by: Serge Hallyn <[email protected]>
Signed-off-by: Al Viro <[email protected]>
  • Loading branch information
Sukadev Bhattiprolu authored and Al Viro committed Mar 27, 2009
1 parent 945cf2c commit 289f00e
Showing 1 changed file with 6 additions and 19 deletions.
25 changes: 6 additions & 19 deletions fs/devpts/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,11 @@ static int new_pts_mount(struct file_system_type *fs_type, int flags,
}

/*
* get_init_pts_sb()
* init_pts_mount()
*
* Mount or remount the initial kernel mount of devpts. This type of
* mount maintains the legacy, single-instance semantics, while the
* kernel still allows multiple-instances.
*
* This interface is needed to support multiple namespace semantics in
* devpts while preserving backward compatibility of the current 'single-
Expand All @@ -362,7 +366,7 @@ static int new_pts_mount(struct file_system_type *fs_type, int flags,
* consistently selects the 'single-namespace' superblock even in the
* presence of the private namespace (i.e 'newinstance') super-blocks.
*/
static int get_init_pts_sb(struct file_system_type *fs_type, int flags,
static int init_pts_mount(struct file_system_type *fs_type, int flags,
void *data, struct pts_mount_opts *opts, struct vfsmount *mnt)
{
struct super_block *s;
Expand Down Expand Up @@ -392,23 +396,6 @@ static int get_init_pts_sb(struct file_system_type *fs_type, int flags,
return 0;
}

/*
* Mount or remount the initial kernel mount of devpts. This type of
* mount maintains the legacy, single-instance semantics, while the
* kernel still allows multiple-instances.
*/
static int init_pts_mount(struct file_system_type *fs_type, int flags,
void *data, struct pts_mount_opts *opts, struct vfsmount *mnt)
{
int err;

err = get_init_pts_sb(fs_type, flags, data, opts, mnt);
if (err)
return err;

return err;
}

static int devpts_get_sb(struct file_system_type *fs_type,
int flags, const char *dev_name, void *data, struct vfsmount *mnt)
{
Expand Down

0 comments on commit 289f00e

Please sign in to comment.