Skip to content

Commit

Permalink
[PATCH] remove protection of LANANA-reserved majors
Browse files Browse the repository at this point in the history
Revert all this.  It can cause device-mapper to receive a different major from
earlier kernels and it turns out that the Amanda backup program (via GNU tar,
apparently) checks major numbers on files when performing incremental backups.

Which is a bit broken of Amanda (or tar), but this feature isn't important
enough to justify the churn.

Cc: Ingo Molnar <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
akpm00 authored and Linus Torvalds committed Apr 5, 2007
1 parent c75fd0e commit 2363cc0
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 20 deletions.
2 changes: 0 additions & 2 deletions block/genhd.c
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ int register_blkdev(unsigned int major, const char *name)
/* temporary */
if (major == 0) {
for (index = ARRAY_SIZE(major_names)-1; index > 0; index--) {
if (is_lanana_major(index))
continue;
if (major_names[index] == NULL)
break;
}
Expand Down
14 changes: 0 additions & 14 deletions drivers/base/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,20 +27,6 @@
int (*platform_notify)(struct device * dev) = NULL;
int (*platform_notify_remove)(struct device * dev) = NULL;

/*
* Detect the LANANA-assigned LOCAL/EXPERIMENTAL majors
*/
bool is_lanana_major(unsigned int major)
{
if (major >= 60 && major <= 63)
return 1;
if (major >= 120 && major <= 127)
return 1;
if (major >= 240 && major <= 254)
return 1;
return 0;
}

/*
* sysfs bindings for devices.
*/
Expand Down
2 changes: 0 additions & 2 deletions fs/char_dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,6 @@ __register_chrdev_region(unsigned int major, unsigned int baseminor,
/* temporary */
if (major == 0) {
for (i = ARRAY_SIZE(chrdevs)-1; i > 0; i--) {
if (is_lanana_major(i))
continue;
if (chrdevs[i] == NULL)
break;
}
Expand Down
2 changes: 0 additions & 2 deletions include/linux/kdev_t.h
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,6 @@ static inline unsigned sysv_minor(u32 dev)
return dev & 0x3ffff;
}

bool is_lanana_major(unsigned int major);

#else /* __KERNEL__ */

/*
Expand Down

0 comments on commit 2363cc0

Please sign in to comment.