devres: fix a for loop bounds check

The iomap[] array has PCIM_IOMAP_MAX (6) elements and not DEVICE_COUNT_RESOURCE (16). This bug was found using a static checker. It may be that the "if (!(mask & (1 << i)))" check means we never actually go past the end of the array in real life. Fixes: ec04b07 ('iomap: implement pcim_iounmap_regions()') Signed-off-by: Dan Carpenter <[email protected]> Acked-by: Tejun Heo <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
chewitt · Oct 5, 2015 · 1f35d04 · 1f35d04
1 parent a785ce9
commit 1f35d04
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/devres.c b/lib/devres.c
@@ -418,7 +418,7 @@ void pcim_iounmap_regions(struct pci_dev *pdev, int mask)
 	if (!iomap)
 		return;
 
-	for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) {
+	for (i = 0; i < PCIM_IOMAP_MAX; i++) {
 		if (!(mask & (1 << i)))
 			continue;