ext4: do not mark superblock as dirty unnecessarily

Commit a037515 cleaned up superblock dirtying handling, but missed one place. This patch does what was intended: if we have the journal, then we update the superblock through the journal rather than doing this directly. Signed-off-by: Artem Bityutskiy <[email protected]> Signed-off-by: "Theodore Ts'o" <[email protected]>
chewitt · Mar 22, 2012 · 1b8b975 · 1b8b975
1 parent 7335519
commit 1b8b975
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
@@ -3935,10 +3935,8 @@ static int ext4_do_update_inode(handle_t *handle,
 			ext4_update_dynamic_rev(sb);
 			EXT4_SET_RO_COMPAT_FEATURE(sb,
 					EXT4_FEATURE_RO_COMPAT_LARGE_FILE);
-			sb->s_dirt = 1;
 			ext4_handle_sync(handle);
-			err = ext4_handle_dirty_metadata(handle, NULL,
-					EXT4_SB(sb)->s_sbh);
+			err = ext4_handle_dirty_super(handle, sb);
 		}
 	}
 	raw_inode->i_generation = cpu_to_le32(inode->i_generation);