Skip to content

Commit

Permalink
[SCSI] mpt fusion: Cleanup some duplicate calls in mptbase.c
Browse files Browse the repository at this point in the history
In mpt_detach, call to pci_set_drvdata is redundant because it
has already been called in mpt_adapter_disable. In mpt_attach,
ioc->pcidev is set to pdev two times.

Signed-off-by: Bandan Das <[email protected]>
Acked-by: "Desai, Kashyap" <[email protected]>
Signed-off-by: James Bottomley <[email protected]>
  • Loading branch information
Bandan Das authored and James Bottomley committed Jul 27, 2010
1 parent c817ce8 commit 15f7fc0
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/message/fusion/mptbase.c
Original file line number Diff line number Diff line change
Expand Up @@ -1770,7 +1770,6 @@ mpt_attach(struct pci_dev *pdev, const struct pci_device_id *id)
ioc->req_sz = MPT_DEFAULT_FRAME_SIZE; /* avoid div by zero! */
ioc->reply_sz = MPT_REPLY_FRAME_SIZE;

ioc->pcidev = pdev;

spin_lock_init(&ioc->taskmgmt_lock);
mutex_init(&ioc->internal_cmds.mutex);
Expand Down Expand Up @@ -2054,7 +2053,6 @@ mpt_detach(struct pci_dev *pdev)

mpt_adapter_dispose(ioc);

pci_set_drvdata(pdev, NULL);
}

/**************************************************************************
Expand Down

0 comments on commit 15f7fc0

Please sign in to comment.