Skip to content

Commit

Permalink
pch_gbe: Fix build error by selecting all the possible dependencies.
Browse files Browse the repository at this point in the history
Fengguang reported a kernel build failure as following:
drivers/built-in.o: In function `pch_gbe_ioctl':
pch_gbe_main.c:(.text+0x510370): undefined reference to `pch_ch_control_write'
pch_gbe_main.c:(.text+0x510393): undefined reference to `pch_ch_control_write'
pch_gbe_main.c:(.text+0x5103b3): undefined reference to `pch_ch_control_write'
...

It's a regression by commit da15864. The root cause is that
the CONFIG_PPS is not set there, consequently CONFIG_PTP_1588_CLOCK
can not be set anyway, which finally causes ptp_pch and pch_gbe_main
build failures.

As David prefers to use *select* to fix such module co-dependency issues,
this patch explicitly selects all the possible dependencies of PCH_PTP.

Reported-by: Fengguang Wu <[email protected]>
Reviewed-by: David S. Miller <[email protected]>
Signed-off-by: Haicheng Li <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
haichengli authored and davem330 committed Oct 9, 2012
1 parent 3db6857 commit 0f79657
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ if PCH_GBE
config PCH_PTP
bool "PCH PTP clock support"
default n
depends on EXPERIMENTAL
select PPS
select PTP_1588_CLOCK
select PTP_1588_CLOCK_PCH
---help---
Say Y here if you want to use Precision Time Protocol (PTP) in the
Expand Down

0 comments on commit 0f79657

Please sign in to comment.