Fix float16 min and max (apache#9149)

* Add unittest for float16 min and max * Add mshadow fix
chaoyuaw · Dec 20, 2017 · 080d29c · 080d29c
1 parent c71a2f3
commit 080d29c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/mshadow b/mshadow
diff --git a/tests/python/unittest/test_operator.py b/tests/python/unittest/test_operator.py
@@ -4668,6 +4668,14 @@ def test_slice_forward_backward(a, index):
     check_numeric_gradient(slice_sym, [in_data])
 
 
+def test_float16_min_max():
+    """Test for issue: https://github.com/apache/incubator-mxnet/issues/9007"""
+    a = mx.nd.array([np.finfo('float16').min, np.finfo('float16').max], dtype='float16')
+    assert a.dtype == np.float16
+    assert np.finfo('float16').min == mx.nd.min(a).asscalar()
+    assert np.finfo('float16').max == mx.nd.max(a).asscalar()
+
+
 if __name__ == '__main__':
     import nose
     nose.runmodule()