Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: S3-based migration source #38068

Merged
merged 5 commits into from
Nov 25, 2020
Merged

Conversation

dillaman
Copy link

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

Copy link
Contributor

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Jason Dillaman added 5 commits November 23, 2020 08:45
This will allow the logic to be re-used between the standard
HTTP stream and the future S3 stream.

Signed-off-by: Jason Dillaman <[email protected]>
The S3 authentication scheme requires adding additional headers to the
outbound request as well as computing a secure signature for the request
using the secret key.

Signed-off-by: Jason Dillaman <[email protected]>
Move the processing of common HTTP result codes (not found, permission
denied, etc) higher up the stack so it can be re-used between all
request paths.

Signed-off-by: Jason Dillaman <[email protected]>
The new S3 stream requires a fully qualified URL to a bucket
(i.e. no virtual host names) along with the access and secret
keys to the bucket.

Signed-off-by: Jason Dillaman <[email protected]>
@dillaman
Copy link
Author

(rebased to include Clang fix)

@trociny trociny merged commit 8dbb87c into ceph:master Nov 25, 2020
@dillaman dillaman deleted the wip-librbd-migration-4 branch November 25, 2020 15:35
@mykaul
Copy link
Contributor

mykaul commented Nov 25, 2020

Is documentation on this feature available (or in a separate commit) ?

@dillaman
Copy link
Author

Is documentation on this feature available (or in a separate commit) ?

Documentation will be added before Pacific (and integration tests pending resolution of various Sepia lab issues)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants