mon: osd create: add optional 'id' parameter #3743
Conversation
|
See also discussion on ceph-user under the thread "ceph-osd - No Longer Creates osd.X upon Launch - Bug ?". |
|
SUCCESS: the output of run-make-check.sh on centos-centos7 for f5a2342 is http://paste2.org/_zscbvsPf |
Sent from 
ghost
added
|
@trociny could you please rebase ? |
|
SUCCESS: the output of run-make-check.sh on centos-7 for 54c2ab8 is http://paste2.org/I62513IX |
| "name=uuid,type=CephUUID,req=false", \ | ||
| "create new osd (with optional UUID)", "osd", "rw", "cli,rest") | ||
| "name=uuid,type=CephUUID,req=false " \ | ||
| "name=id,type=CephInt,req=false", \ |
There was a problem hiding this comment.
could specify the range of id, like the way how osd find does. i.e.
name=id,type=CephInt,range=0
see https://www.mail-archive.com/[email protected]/msg16825.html . |
|
Rebased after addressing @tchaikov's suggestions. |
| i = pending_inc.identify_osd(uuid); | ||
| if (id >= 0) { | ||
| // Both id and uuid provided. Check they do not conflict with existing. | ||
| if (i < 0) { |
There was a problem hiding this comment.
indentation seems wrong. this may be github playing tricks, but please check to make sure that's not a single white-space.
There was a problem hiding this comment.
Rechecked. Indentation is ok here (according to -- mode:C++; tab-width:8; c-basic-offset:2; indent-tabs-mode:t --)
|
Rebased after addressing @jecluis comments. |
|
Rebased after fixing s/not match/does not match/. |
Signed-off-by: Mykola Golub <[email protected]>
|
@jecluis how do you like this version? |
|
This looks fine to me. Sorry for the delay -- forgot about this pull request! :(
|
mon: osd create: add optional 'id' parameter Reviewed-by: Joao Eduardo Luis <[email protected]>
Signed-off-by: Mykola Golub [email protected]