Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailmap, organizationmap: add Dongsheng, Liuzhong, Pengcheng, Yang Affiliation #17548

Merged
merged 2 commits into from
Sep 7, 2017

Conversation

yangdongsheng
Copy link
Contributor

Signed-off-by: Dongsheng Yang [email protected]

.organizationmap Outdated
@@ -135,7 +135,10 @@ EISOO <[email protected]> lu.shasha <[email protected]>
Enproduktion GmbH <[email protected]> Malte Fiala <[email protected]>
EPAM <[email protected]> Andrey Kuznetsov <[email protected]>
Exalead <[email protected]> <[email protected]>
Easystack <[email protected]> chenliuzhong <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is a github username chenliuzhong. Please provide your actual name here, which is usually a display name in the Email. It should be in the alphabetical order with in the group Easystack too.

.organizationmap Outdated
@@ -135,7 +135,10 @@ EISOO <[email protected]> lu.shasha <[email protected]>
Enproduktion GmbH <[email protected]> Malte Fiala <[email protected]>
EPAM <[email protected]> Andrey Kuznetsov <[email protected]>
Exalead <[email protected]> <[email protected]>
Easystack <[email protected]> chenliuzhong <[email protected]>
Easystack <[email protected]> kungf <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

.organizationmap Outdated
Easystack <[email protected]> Dongsheng Yang <[email protected]>
Easystack <[email protected]> PCzhangPC <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

.mailmap Outdated
@@ -74,6 +74,7 @@ Clement Lebrun <[email protected]> <[email protected]>
Colin P. McCabe <[email protected]> <[email protected]>
Colin P. McCabe <[email protected]> <[email protected]>
Colin Walters <[email protected]> <[email protected]>
chenliuzhong <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is a github username chenliuzhong. Please provide your actual name here in the alphabetical order.

@tchaikov Could you please suggest if this entry is necessary as chenliuzhong is having only one Email ID ? Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah keeping an entry in mailmap always helps when there are future mistakes etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theanalyst oh okay, I have seen many people with single emails in .mailmap.

.mailmap Outdated
@@ -225,6 +226,7 @@ Ken Dreyer <[email protected]>
Kévin Caradant <[email protected]>
Kiseleva Alyona <[email protected]>
Kongming Wu <[email protected]>
kungf <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

.mailmap Outdated
@@ -287,6 +289,7 @@ Noah Watkins <[email protected]> <[email protected]>
Noah Watkins <[email protected]> <[email protected]>
Orit Wasserman <[email protected]> <[email protected]>
Orit Wasserman <[email protected]> <[email protected]>
PCzhangPC <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@joscollin joscollin changed the title mailmap: add PCzhangPC, chenliuzhong, kungf into mailmap and organiza… mailmap, organizationmap: add PCzhangPC, chenliuzhong, kungf Sep 7, 2017
@yangdongsheng
Copy link
Contributor Author

@joscollin thanx for your review. Please take a look this version. The first two commits are sorting the mailmap and organizationmap by sort command.

Copy link
Member

@joscollin joscollin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first two commits are sorting the mailmap and organizationmap by sort command.

I would suggest to revert this change in this PR, as you are diverting from the original purpose of this PR. Fix only your own entries (for PCzhangPC, chenliuzhong, kungf). And the rest can be done as another PR if necessary.

@yangdongsheng
Copy link
Contributor Author

#17567 @joscollin

@yangdongsheng
Copy link
Contributor Author

@theanalyst @joscollin drop the sorting commits now. Lets sort them later as @theanalyst mentioned in #17567

Copy link
Member

@joscollin joscollin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM.

However, the alphabetic reordering of .organizationmap and .mailmap to be done as a separate PR. I see some invalid entries too - to be changed in another PR.

@joscollin joscollin changed the title mailmap, organizationmap: add PCzhangPC, chenliuzhong, kungf mailmap, organizationmap: add Dongsheng, Liuzhong, Pengcheng, Yang Affiliation Sep 7, 2017
@joscollin joscollin merged commit 404e396 into ceph:master Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants