resolves some of the linter issues

test/e2e/minor_version_compatibility.go

@@ -55,7 +55,7 @@ func MinorVersionCompatibility(logger *log.Logger) error {
 		// each node begins with a random version within the same major version set
 		v := versions.Random(r).String()
 		logger.Println("Starting node", "node", i, "version", v)
-		var disableBBR = false
+		disableBBR := false
 		// bbr is only available after a certain version,
 		// the flag needs to be passed only for versions that support it
 		if isBBRCompatible(v) {
@@ -93,7 +93,7 @@ func MinorVersionCompatibility(logger *log.Logger) error {
 
 		newVersion := versions.Random(r).String()
 		logger.Println("Upgrading node", "node", i%numNodes+1, "version", newVersion)
-		var disableBBR = false
+		disableBBR := false
 		// bbr is only available after a certain version,
 		// the flag needs to be passed only for versions that support it
 		if isBBRCompatible(newVersion) {
@@ -142,8 +142,5 @@ func getAllVersions() (string, error) {
 // isBBRCompatible returns true if version is bbr compatible
 // MUST be called only for versions that follow semver
 func isBBRCompatible(v string) bool {
-	if v >= "v2.1.2" {
-		return true
-	}
-	return false
+	return v >= "v2.1.2"
 }

test/e2e/testnet/node.go

@@ -370,12 +370,12 @@
 	}
 }
 
 func (n *Node) Upgrade(version string, disableBBR bool) error {
 	if err := n.Instance.SetImageInstant(DockerImageName(version)); err != nil {
 		return err
 	}
 
-	//if disableBBR {
+	// if disableBBR {
 	//	// FIXME: This does not work currently since the node is not in state 'Preparing' or 'Committed'
 	//	//n.args = append(n.args, "--force-no-bbr")
 	//	//err := n.Instance.SetArgs(n.args...)
@@ -394,12 +394,3 @@
 func (n *Node) GetArgs() []string {
 	return n.args
 }
-
-func contains(slice []string, str string) bool {
-	for _, v := range slice {
-		if v == str {
-			return true
-		}
-	}
-	return false
-}