fix: state sync on main #3811
fix: state sync on main #3811
Conversation
WalkthroughWalkthroughThe changes introduce enhancements to the Changes
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (4)
Additional context usedShellcheck
Additional comments not posted (8)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| @@ -0,0 +1,59 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
Use #!/bin/bash for better compatibility.
The shebang #!/bin/sh may not support all features used in the script. Consider using #!/bin/bash for better compatibility.
-#!/bin/sh
+#!/bin/bashCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #!/bin/sh | |
| #!/bin/bash |
|
|
||
| # Ask the user for confirmation before deleting the existing celestia-app home | ||
| # directory. | ||
| read -p "Are you sure you want to delete: $CELESTIA_APP_HOME? [y/n] " response |
There was a problem hiding this comment.
Replace read -p with a POSIX-compliant alternative.
The read -p option is not defined in POSIX sh. Use printf and read instead for better compatibility.
-read -p "Are you sure you want to delete: $CELESTIA_APP_HOME? [y/n] " response
+printf "Are you sure you want to delete: %s? [y/n] " "$CELESTIA_APP_HOME"
+read responseCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| read -p "Are you sure you want to delete: $CELESTIA_APP_HOME? [y/n] " response | |
| printf "Are you sure you want to delete: %s? [y/n] " "$CELESTIA_APP_HOME" | |
| read response |
Tools
Shellcheck
[warning] 25-25: In POSIX sh, read -p is undefined.
(SC3045)
| fi | ||
|
|
||
| echo "Deleting $CELESTIA_APP_HOME..." | ||
| rm -r "$CELESTIA_APP_HOME" |
There was a problem hiding this comment.
Add -f flag to rm for safety.
Using rm -r without -f can be dangerous if the directory doesn't exist or if there are permission issues. Add -f to force removal.
-rm -r "$CELESTIA_APP_HOME"
+rm -rf "$CELESTIA_APP_HOME"Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| rm -r "$CELESTIA_APP_HOME" | |
| rm -rf "$CELESTIA_APP_HOME" |
|
|
||
| # Ask the user for confirmation before deleting the existing celestia-app home | ||
| # directory. | ||
| read -p "Are you sure you want to delete: $CELESTIA_APP_HOME? [y/n] " response |
There was a problem hiding this comment.
Replace read -p with a POSIX-compliant alternative.
The read -p option is not defined in POSIX sh. Use printf and read instead for better compatibility.
-read -p "Are you sure you want to delete: $CELESTIA_APP_HOME? [y/n] " response
+printf "Are you sure you want to delete: %s? [y/n] " "$CELESTIA_APP_HOME"
+read responseCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| read -p "Are you sure you want to delete: $CELESTIA_APP_HOME? [y/n] " response | |
| printf "Are you sure you want to delete: %s? [y/n] " "$CELESTIA_APP_HOME" | |
| read response |
Tools
Shellcheck
[warning] 25-25: In POSIX sh, read -p is undefined.
(SC3045)
| fi | ||
|
|
||
| echo "Deleting $CELESTIA_APP_HOME..." | ||
| rm -r "$CELESTIA_APP_HOME" |
There was a problem hiding this comment.
Add -f flag to rm for safety.
Using rm -r without -f can be dangerous if the directory doesn't exist or if there are permission issues. Add -f to force removal.
-rm -r "$CELESTIA_APP_HOME"
+rm -rf "$CELESTIA_APP_HOME"Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| rm -r "$CELESTIA_APP_HOME" | |
| rm -rf "$CELESTIA_APP_HOME" |
| @@ -0,0 +1,59 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
Use #!/bin/bash for better compatibility.
The shebang #!/bin/sh may not support all features used in the script. Consider using #!/bin/bash for better compatibility.
-#!/bin/sh
+#!/bin/bashCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #!/bin/sh | |
| #!/bin/bash |
Forward port of #3808