Removed Jython bz2 import fallback #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atombrella
force-pushed
the
jython_bz2
branch
2 times, most recently
from
8fe89c4
to
172a585
Compare
atombrella
force-pushed
the
jython_bz2
branch
from
172a585
to
efdd29b
Compare
Codecov Report
@@ Coverage Diff @@
## master #938 +/- ##
==========================================
- Coverage 88.66% 88.66% -0.01%
==========================================
Files 63 63
Lines 6512 6509 -3
Branches 776 776
==========================================
- Hits 5774 5771 -3
Misses 656 656
Partials 82 82
Continue to review full report at Codecov.
|
atombrella
commented
Oct 28, 2018
| @@ -10,7 +10,7 @@ all_files = 1 | |||
| [flake8] | |||
| # classes can be lowercase, arguments and variables can be uppercase | |||
| # whenever it makes the code more readable. | |||
| ignore = N806, N802, N801, N803 | |||
| ignore = W504, N806, N802, N801, N803 | |||
There was a problem hiding this comment.
flake8 raised a lot of warnings (not locally, only on Travis) without this change.
|
Thanks! |
hakjoon
added a commit
to hakjoon/kombu
that referenced
this pull request
Feb 6, 2019
Removed in celery#938 due to assumption that it only affected Jython but the condition can be present in systems built without bz2 support. Systems without bz2 work in 4.2.2 but fail in 4.3.0
hakjoon
added a commit
to hakjoon/kombu
that referenced
this pull request
Feb 6, 2019
Removed in celery#938 due to assumption that it only affected Jython but the condition can be present in systems built without bz2 support.
thedrow
pushed a commit
that referenced
this pull request
Feb 8, 2019
Removed in #938 due to assumption that it only affected Jython but the condition can be present in systems built without bz2 support.
netbsd-srcmastr
referenced
this pull request
in NetBSD/pkgsrc
Mar 6, 2019
4.4.0: - Restore bz2 import checks in compression module. The checks were removed in celery/kombu-938 <https://github.com/celery/kombu/pull/938>_ due to assumption that it only affected Jython. However, bz2 support can be missing in Pythons built without bz2 support. - Fix regression that occurred in 4.3.0 when parsing Redis Sentinel master URI containing password. - Handle the case when only one Redis Sentinel node is provided. - Support SSL URL parameters correctly for rediss:// URIs. - Revert celery/kombu-954 <https://github.com/celery/kombu/pull/954>_. Instead bump the required redis-py dependency to 3.2.0 to include this fix redis/redis-py@4e1e748 <https://github.com/andymccurdy/redis-py/commit/4e1e74809235edc19e03edb79c97c80a3e4e9eca>_. - Added support for broadcasting using a regular expression pattern or a glob pattern to multiple Pidboxes.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to have been resolved. The touched lines were from 2011, and the satus of the buf changed in 2013. I didn't check on Jython, my suggestion is only based on that report.
http://bugs.jython.org/issue1445