Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control of fan levels #3

Closed
avylove opened this issue Jun 4, 2022 · 2 comments
Closed

Control of fan levels #3

avylove opened this issue Jun 4, 2022 · 2 comments

Comments

@avylove
Copy link

avylove commented Jun 4, 2022

Great project! I installed the RPM and it pretty much worked out of the box.

The only issue I'm running into is the low speed on my machine isn't particularly low, so I'm wondering if you can add a configuration option to set what the levels correspond to. That, or support specifying levels as integers instead of by label.

To give some context, here is what I'm observing on my system:

Level RPMS
0 0
1 2820
2 3360
3 3670
4 3670
5 3670
6 4020
7 4570

As you can see, there's no difference between levels 3 through 5 and 2 is not much slower, so on my system it would make sense to make low_temp level 1 instead of level 2. I imagine there is always going to be some variance with hardware so, while I love that zcfan works well out of the box, fine tuning is still desired.

cdown added a commit that referenced this issue Jun 7, 2022
@cdown
Copy link
Owner

cdown commented Jun 7, 2022

Hi there! Glad you find zcfan useful.

While it's possible to allow specifying the level for each temperature, it would certainly make the code more complex, and I'd rather avoid getting into thinkfan territory and keep things as low config as possible. I think that based on what you've identified, the best thing to do is just to change "low" to be set to 1. On my T14s, that gets exactly the same fan speed anyway.

I've just shipped a change to that effect. Thanks! Let me know if that solves your issue and I'll make a new release soon.

@cdown
Copy link
Owner

cdown commented Jul 23, 2022

1.2.0 now out with this change. Thanks!

@cdown cdown closed this as completed Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants