Decompress response body string if it was compressed #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rmstar
commented
Feb 10, 2023
rmstar
commented
- getResponseBodyAsString() now returns uncompressed data if response was compressed using gzip or deflate
- Added new API getUncompressedResponseBody() that returns uncompressed response as bytes if it was response was compressed
- Upgraded checkstyle version (now using same version as cdap repo) and fixed checkstyle issues
tivv
reviewed
Feb 10, 2023
common-cli/pom.xml
Outdated
| @@ -22,7 +22,7 @@ the License. | |||
| <parent> | |||
| <artifactId>common</artifactId> | |||
| <groupId>io.cdap.common</groupId> | |||
| <version>0.13.0-SNAPSHOT</version> | |||
| <version>0.13.1</version> | |||
There was a problem hiding this comment.
Please put "-SNAPSHOT until after released
| throw new IllegalStateException(String.format("Failed to decompress %s encoded response body", encoding), e); | ||
| } | ||
|
|
||
| throw new IllegalArgumentException("Unsupported content encoding " + encoding); |
There was a problem hiding this comment.
Use IllegalStateException as it's not an argument
added test |
tivv
approved these changes
Feb 10, 2023
rmstar
added a commit
that referenced
this pull request
Feb 11, 2023
Cherrypick #59 and version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.