Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pip upgrades temporarily #236

Closed
wants to merge 2 commits into from
Closed

Disable pip upgrades temporarily #236

wants to merge 2 commits into from

Conversation

wildlyinaccurate
Copy link
Contributor

So #235 didn't seem to fix anything. In the mean time, I wonder if it's better to use flat-out disable the pip upgrades? At least until there's a resolution to pypa/pip#6169.

@pmeenan
Copy link
Contributor

pmeenan commented Jan 23, 2019

I think the problem is that the modules were originally installed as sudo and it used to silently fail before (and the code would try normal user first and then sudo). Since the modules are only upgraded on EC2 and GCE and both images were installed as sudo I changed the code to only update using sudo and I believe it is working now (testing a fresh image now to be sure).

@pmeenan pmeenan closed this Jan 23, 2019
@wildlyinaccurate wildlyinaccurate deleted the skip-pip-upgrades-temporary branch January 23, 2019 20:32
@wildlyinaccurate
Copy link
Contributor Author

Oh, nice! Thanks Pat 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants