Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing break lines in get_db_snr_map() #913

Merged
merged 2 commits into from
Jan 14, 2022

Conversation

lars18th
Copy link
Contributor

Fixes coverity errors introduced with PR #912 (comment)

@lars18th
Copy link
Contributor Author

Hi @catalinii ,

In my repo the coverity test over mips platform returns this error:

mipsel-tuxbox-linux-gnu-gcc -Wall -Wno-switch -ggdb -fPIC   -DMINOR=\"\" -DDISABLE_DVBAES -DDISABLE_DVBCA -DDISABLE_NETCVCLIENT -DDISABLE_DDCI -DDISABLE_T2MI -DENIGMA -c dvb.c -o ../build/dvb.o
dvb.c: In function 'get_db_snr_map':
dvb.c:353:10: error: 'SYS_DVBC_ANNEX_C' undeclared (first use in this function)
     case SYS_DVBC_ANNEX_C: /* not sure, to be tested */
          ^
dvb.c:353:10: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [Makefile:155: ../build/dvb.o] Error 1
make[1]: Leaving directory '/__w/minisatip/minisatip/src'
make: *** [Makefile:11: minisatip] Error 2

I want to hear your opinion: You prefer to remove the case SYS_DVBC_ANNEX_C from the code? I feel this modulation is not used with minisatip, and if we remove it then other ancient mips platforms (E2) will not fail to compile.

You agree with this additional change?

@lars18th
Copy link
Contributor Author

Hi @catalinii ,

I finally removed the SYS_DVBC_ANNEX_C from get_db_snr_map() too to fix https://github.com/catalinii/minisatip/runs/4675651488?check_suite_focus=true

So, it's ready to merge. Please check it!

@catalinii catalinii merged commit 1f40bbe into catalinii:master Jan 14, 2022
@lars18th lars18th deleted the fix-snr branch January 15, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants